sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-30 22:53:59 +00:00
Code Issues Releases Wiki Activity

fix esp32 rmt receiver item array length (#2671)

Browse Source
This commit is contained in:
Guillermo Ruffino
2021-11-09 21:15:02 -03:00
committed by GitHub
parent fb57ab0add
commit 57b07441a1
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
esphome/components/remote_receiver/remote_receiver_esp32.cpp
View File

@@ -78,6 +78,7 @@ void RemoteReceiverComponent::loop() {
if (this->temp_.empty()) if (this->temp_.empty())
return; return;
this->temp_.push_back(-this->idle_us_);
this->call_listeners_dumpers_(); this->call_listeners_dumpers_();
} }
} }
@@ -86,9 +87,10 @@ void RemoteReceiverComponent::decode_rmt_(rmt_item32_t *item, size_t len) {
uint32_t prev_length = 0; uint32_t prev_length = 0;
this->temp_.clear(); this->temp_.clear();
int32_t multiplier = this->pin_->is_inverted() ? -1 : 1; int32_t multiplier = this->pin_->is_inverted() ? -1 : 1;
size_t item_count = len / sizeof(rmt_item32_t);
ESP_LOGVV(TAG, "START:"); ESP_LOGVV(TAG, "START:");
for (size_t i = 0; i < len; i++) { for (size_t i = 0; i < item_count; i++) {
if (item[i].level0) { if (item[i].level0) {
ESP_LOGVV(TAG, "%u A: ON %uus (%u ticks)", i, this->to_microseconds_(item[i].duration0), item[i].duration0); ESP_LOGVV(TAG, "%u A: ON %uus (%u ticks)", i, this->to_microseconds_(item[i].duration0), item[i].duration0);
} else { } else {
@@ -102,8 +104,8 @@ void RemoteReceiverComponent::decode_rmt_(rmt_item32_t *item, size_t len) {
} }
ESP_LOGVV(TAG, "\n"); ESP_LOGVV(TAG, "\n");
this->temp_.reserve(len / 4); this->temp_.reserve(item_count * 2); // each RMT item has 2 pulses
for (size_t i = 0; i < len; i++) { for (size_t i = 0; i < item_count; i++) {
if (item[i].duration0 == 0u) { if (item[i].duration0 == 0u) {
// Do nothing // Do nothing
} else if (bool(item[i].level0) == prev_level) { } else if (bool(item[i].level0) == prev_level) {
@@ -120,10 +122,6 @@ void RemoteReceiverComponent::decode_rmt_(rmt_item32_t *item, size_t len) {
prev_length = item[i].duration0; prev_length = item[i].duration0;
} }
if (this->to_microseconds_(prev_length) > this->idle_us_) {
break;
}
if (item[i].duration1 == 0u) { if (item[i].duration1 == 0u) {
// Do nothing // Do nothing
} else if (bool(item[i].level1) == prev_level) { } else if (bool(item[i].level1) == prev_level) {
@@ -139,10 +137,6 @@ void RemoteReceiverComponent::decode_rmt_(rmt_item32_t *item, size_t len) {
prev_level = bool(item[i].level1); prev_level = bool(item[i].level1);
prev_length = item[i].duration1; prev_length = item[i].duration1;
} }
if (this->to_microseconds_(prev_length) > this->idle_us_) {
break;
}
} }
if (prev_length > 0) { if (prev_length > 0) {
if (prev_level) { if (prev_level) {