sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-03-15 15:18:16 +00:00
Code Issues Releases Wiki Activity

fix clang tidy

Browse Source
This commit is contained in:
Tomasz Duda 2024-07-24 15:25:55 +02:00
parent 4224689f1c
commit 4a0a14635a
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
esphome/components/text/text_traits.h
View File

@ -21,7 +21,7 @@ class TextTraits {
int get_max_length() const { return this->max_length_; } int get_max_length() const { return this->max_length_; }
// Set/get the pattern. // Set/get the pattern.
void set_pattern(std::string pattern) { this->pattern_ = std::move(pattern); } void set_pattern(const std::string &pattern) { this->pattern_ = std::move(pattern); }
std::string get_pattern() const { return this->pattern_; } std::string get_pattern() const { return this->pattern_; }
// Set/get the frontend mode. // Set/get the frontend mode.

2
esphome/components/time/real_time_clock.h
View File

@ -37,7 +37,7 @@ class RealTimeClock : public PollingComponent {
void call_setup() override; void call_setup() override;
void add_on_time_sync_callback(std::function<void()> callback) { void add_on_time_sync_callback(const std::function<void()> &callback) {
this->time_sync_callback_.add(std::move(callback)); this->time_sync_callback_.add(std::move(callback));
}; };

14
esphome/components/zephyr/preferences.cpp
View File

@ -53,8 +53,8 @@ class ZephyrPreferences : public ESPPreferences {
static struct settings_handler settings_cb = { static struct settings_handler settings_cb = {
.name = ESPHOME_SETTINGS_KEY, .name = ESPHOME_SETTINGS_KEY,
.h_set = load_setting_, .h_set = load_setting,
.h_export = export_settings_, .h_export = export_settings,
}; };
err = settings_register(&settings_cb); err = settings_register(&settings_cb);
@ -76,7 +76,7 @@ class ZephyrPreferences : public ESPPreferences {
} }
ESPPreferenceObject make_preference(size_t length, uint32_t type) override { ESPPreferenceObject make_preference(size_t length, uint32_t type) override {
for (auto backend : this->backends_) { for (auto *backend : this->backends_) {
if (backend->get_type() == type) { if (backend->get_type() == type) {
return ESPPreferenceObject(backend); return ESPPreferenceObject(backend);
} }
@ -100,7 +100,7 @@ class ZephyrPreferences : public ESPPreferences {
bool reset() override { bool reset() override {
ESP_LOGD(TAG, "Reset settings"); ESP_LOGD(TAG, "Reset settings");
for (auto backend : this->backends_) { for (auto *backend : this->backends_) {
// save empty delete data // save empty delete data
backend->data.clear(); backend->data.clear();
} }
@ -111,7 +111,7 @@ class ZephyrPreferences : public ESPPreferences {
protected: protected:
std::vector<ZephyrPreferenceBackend *> backends_; std::vector<ZephyrPreferenceBackend *> backends_;
static int load_setting_(const char *name, size_t len, settings_read_cb read_cb, void *cb_arg) { static int load_setting(const char *name, size_t len, settings_read_cb read_cb, void *cb_arg) {
auto type = parse_hex<uint32_t>(name); auto type = parse_hex<uint32_t>(name);
if (!type.has_value()) { if (!type.has_value()) {
std::string full_name(ESPHOME_SETTINGS_KEY); std::string full_name(ESPHOME_SETTINGS_KEY);
@ -130,8 +130,8 @@ class ZephyrPreferences : public ESPPreferences {
return 0; return 0;
} }
static int export_settings_(int (*cb)(const char *name, const void *value, size_t val_len)) { static int export_settings(int (*cb)(const char *name, const void *value, size_t val_len)) {
for (auto backend : static_cast<ZephyrPreferences *>(global_preferences)->backends_) { for (auto *backend : static_cast<ZephyrPreferences *>(global_preferences)->backends_) {
auto name = backend->get_key(); auto name = backend->get_key();
int err = cb(name.c_str(), backend->data.data(), backend->data.size()); int err = cb(name.c_str(), backend->data.data(), backend->data.size());
ESP_LOGD(TAG, "save in flash, name %s, len %u, err %d", name.c_str(), backend->data.size(), err); ESP_LOGD(TAG, "save in flash, name %s, len %u, err %d", name.c_str(), backend->data.size(), err);