sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-30 22:53:59 +00:00
Code Issues Releases Wiki Activity

Eliminate web_server_idf guard variable to save 8 bytes RAM (#9344)

Browse Source
This commit is contained in:
J. Nick Koston
2025-07-06 05:06:32 -05:00
committed by GitHub
parent 0bc18a8281
commit 4673a5b48c
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
esphome/components/web_server_idf/web_server_idf.cpp
View File

@@ -37,6 +37,15 @@ namespace web_server_idf {
static const char *const TAG = "web_server_idf"; static const char *const TAG = "web_server_idf";
// Global instance to avoid guard variable (saves 8 bytes)
// This is initialized at program startup before any threads
namespace {
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
DefaultHeaders default_headers_instance;
} // namespace
DefaultHeaders &DefaultHeaders::Instance() { return default_headers_instance; }
void AsyncWebServer::end() { void AsyncWebServer::end() {
if (this->server_) { if (this->server_) {
httpd_stop(this->server_); httpd_stop(this->server_);

5
esphome/components/web_server_idf/web_server_idf.h
View File

@@ -328,10 +328,7 @@ class DefaultHeaders {
void addHeader(const char *name, const char *value) { this->headers_.emplace_back(name, value); } void addHeader(const char *name, const char *value) { this->headers_.emplace_back(name, value); }
// NOLINTNEXTLINE(readability-identifier-naming) // NOLINTNEXTLINE(readability-identifier-naming)
static DefaultHeaders &Instance() { static DefaultHeaders &Instance();
static DefaultHeaders instance;
return instance;
}
protected: protected:
std::vector<std::pair<std::string, std::string>> headers_; std::vector<std::pair<std::string, std::string>> headers_;