sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-09-14 17:22:20 +01:00
Code Issues Releases Wiki Activity

Merge branch 'integration' of https://github.com/esphome/esphome into integration

Browse Source
This commit is contained in:
J. Nick Koston
2025-06-17 15:05:27 +02:00
parent c9edcb909b 1fe3fb25a6
commit 430cee8bda
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
esphome/components/gpio/binary_sensor/gpio_binary_sensor.cpp
View File

@@ -29,7 +29,7 @@ void GPIOBinarySensorStore::setup(InternalGPIOPin *pin, gpio::InterruptType type
void GPIOBinarySensor::setup() { void GPIOBinarySensor::setup() {
if (this->use_interrupt_ && !this->pin_->is_internal()) { if (this->use_interrupt_ && !this->pin_->is_internal()) {
ESP_LOGW(TAG, "Interrupts not supported for this pin type, falling back to polling"); ESP_LOGD(TAG, "GPIO is not internal, falling back to polling mode");
this->use_interrupt_ = false; this->use_interrupt_ = false;
} }

7
esphome/components/gpio/binary_sensor/gpio_binary_sensor.h
View File

@@ -24,6 +24,13 @@ class GPIOBinarySensorStore {
bool has_changed() { bool has_changed() {
// No lock needed: single writer (ISR) / single reader (main loop) pattern // No lock needed: single writer (ISR) / single reader (main loop) pattern
// Volatile bool operations are atomic on all ESPHome-supported platforms // Volatile bool operations are atomic on all ESPHome-supported platforms
//
// Note: There's a benign race where ISR could set changed_ = true between
// our read and clear. This is intentional and causes no issues because:
// 1. We'll process the state change on the next loop iteration
// 2. Multiple rapid changes between loop iterations would only result in
// one update anyway (we only care about the final state)
// 3. This avoids the overhead of atomic operations in the ISR
if (!this->changed_) { if (!this->changed_) {
return false; return false;
} }