sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-09-07 05:42:20 +01:00
Code Issues Releases Wiki Activity

preen

Browse Source
This commit is contained in:
J. Nick Koston
2025-08-02 12:27:54 -10:00
parent 36eab00eac
commit 40dcee594b
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
esphome/core/application.cpp
View File

@@ -37,12 +37,15 @@ static const char *const TAG = "app";
// Helper function for insertion sort of components by setup priority // Helper function for insertion sort of components by setup priority
// Using insertion sort instead of std::stable_sort saves ~1.3KB of flash // Using insertion sort instead of std::stable_sort saves ~1.3KB of flash
// by avoiding template instantiations (std::rotate, std::stable_sort, lambdas) // by avoiding template instantiations (std::rotate, std::stable_sort, lambdas)
// IMPORTANT: This sort is stable (preserves relative order of equal elements),
// which is necessary to maintain user-defined component order for same priority
static void insertion_sort_by_setup_priority(Component **components, size_t size) { static void insertion_sort_by_setup_priority(Component **components, size_t size) {
for (size_t i = 1; i < size; i++) { for (size_t i = 1; i < size; i++) {
Component *key = components[i]; Component *key = components[i];
float key_priority = key->get_actual_setup_priority(); float key_priority = key->get_actual_setup_priority();
int32_t j = i - 1; int32_t j = i - 1;
// Using '<' (not '<=') ensures stability - equal priority components keep their order
while (j >= 0 && components[j]->get_actual_setup_priority() < key_priority) { while (j >= 0 && components[j]->get_actual_setup_priority() < key_priority) {
components[j + 1] = components[j]; components[j + 1] = components[j];
j--; j--;
@@ -52,12 +55,15 @@ static void insertion_sort_by_setup_priority(Component **components, size_t size
} }
// Helper function for insertion sort of components by loop priority // Helper function for insertion sort of components by loop priority
// IMPORTANT: This sort is stable (preserves relative order of equal elements),
// which is required when components are re-sorted during setup() if they block
static void insertion_sort_by_loop_priority(Component **components, size_t size) { static void insertion_sort_by_loop_priority(Component **components, size_t size) {
for (size_t i = 1; i < size; i++) { for (size_t i = 1; i < size; i++) {
Component *key = components[i]; Component *key = components[i];
float key_priority = key->get_loop_priority(); float key_priority = key->get_loop_priority();
int32_t j = i - 1; int32_t j = i - 1;
// Using '<' (not '<=') ensures stability - equal priority components keep their order
while (j >= 0 && components[j]->get_loop_priority() < key_priority) { while (j >= 0 && components[j]->get_loop_priority() < key_priority) {
components[j + 1] = components[j]; components[j + 1] = components[j];
j--; j--;