sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-30 14:43:51 +00:00
Code Issues Releases Wiki Activity

Run clang-tidy against ESP32 (#2147)

Browse Source 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Otto winter <otto@otto-winter.com>
This commit is contained in:
Oxan van Leeuwen
2021-09-13 18:11:27 +02:00
committed by GitHub
parent a2d2863c72
commit 40c474cd83
74 changed files with 291 additions and 364 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
esphome/components/inkbird_ibsth1_mini/inkbird_ibsth1_mini.cpp
View File

@@ -37,25 +37,25 @@ bool InkbirdIBSTH1_MINI::parse_device(const esp32_ble_tracker::ESPBTDevice &devi
ESP_LOGVV(TAG, "parse_device(): address is not public");
return false;
}
if (device.get_service_datas().size() != 0) {
if (!device.get_service_datas().empty()) {
ESP_LOGVV(TAG, "parse_device(): service_data is expected to be empty");
return false;
}
auto mnfDatas = device.get_manufacturer_datas();
if (mnfDatas.size() != 1) {
auto mnf_datas = device.get_manufacturer_datas();
if (mnf_datas.size() != 1) {
ESP_LOGVV(TAG, "parse_device(): manufacturer_datas is expected to have a single element");
return false;
}
auto mnfData = mnfDatas[0];
if (mnfData.uuid.get_uuid().len != ESP_UUID_LEN_16) {
auto mnf_data = mnf_datas[0];
if (mnf_data.uuid.get_uuid().len != ESP_UUID_LEN_16) {
ESP_LOGVV(TAG, "parse_device(): manufacturer data element is expected to have uuid of length 16");
return false;
}
if (mnfData.data.size() != 7) {
if (mnf_data.data.size() != 7) {
ESP_LOGVV(TAG, "parse_device(): manufacturer data element length is expected to be of length 7");
return false;
}
if (mnfData.data[6] != 8) {
if (mnf_data.data[6] != 8) {
ESP_LOGVV(TAG, "parse_device(): unexpected data");
return false;
}
@@ -72,20 +72,20 @@ bool InkbirdIBSTH1_MINI::parse_device(const esp32_ble_tracker::ESPBTDevice &devi
auto external_temperature = NAN;
// Read bluetooth data into variable
auto measured_temperature = mnfData.uuid.get_uuid().uuid.uuid16 / 100.0f;
auto measured_temperature = mnf_data.uuid.get_uuid().uuid.uuid16 / 100.0f;
// Set temperature or external_temperature based on which sensor is in use
if (mnfData.data[2] == 0) {
if (mnf_data.data[2] == 0) {
temperature = measured_temperature;
} else if (mnfData.data[2] == 1) {
} else if (mnf_data.data[2] == 1) {
external_temperature = measured_temperature;
} else {
ESP_LOGVV(TAG, "parse_device(): unknown sensor type");
return false;
}
auto battery_level = mnfData.data[5];
auto humidity = ((mnfData.data[1] << 8) + mnfData.data[0]) / 100.0f;
auto battery_level = mnf_data.data[5];
auto humidity = ((mnf_data.data[1] << 8) + mnf_data.data[0]) / 100.0f;
// Send temperature only if the value is set
if (!isnan(temperature) && this->temperature_ != nullptr) {