sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-30 22:53:59 +00:00
Code Issues Releases Wiki Activity

fixes

Browse Source
This commit is contained in:
J. Nick Koston
2025-07-09 16:27:40 -10:00
parent 7f7623cc8d
commit 33fb4d5d42
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
esphome/analyze_memory.py
View File

@@ -1017,10 +1017,10 @@ class MemoryAnalyzer:
return standard_section return standard_section
return None return None
def parse_symbol_line(line: str) -> tuple[str, str, int] | None: def parse_symbol_line(line: str) -> tuple[str, str, int, str] | None:
"""Parse a single symbol line from objdump output. """Parse a single symbol line from objdump output.
Returns (section, name, size) or None if not a valid symbol. Returns (section, name, size, address) or None if not a valid symbol.
Format: address l/g w/d F/O section size name Format: address l/g w/d F/O section size name
Example: 40084870 l F .iram0.text 00000000 _xt_user_exc Example: 40084870 l F .iram0.text 00000000 _xt_user_exc
""" """
@@ -1029,8 +1029,9 @@ class MemoryAnalyzer:
return None return None
try: try:
# Validate address # Validate and extract address
int(parts[0], 16) address = parts[0]
int(address, 16)
except ValueError: except ValueError:
return None return None
@@ -1047,7 +1048,7 @@ class MemoryAnalyzer:
size = int(parts[i + 1], 16) size = int(parts[i + 1], 16)
if i + 2 < len(parts) and size > 0: if i + 2 < len(parts) and size > 0:
name = " ".join(parts[i + 2 :]) name = " ".join(parts[i + 2 :])
return (section, name, size) return (section, name, size, address)
except ValueError: except ValueError:
pass pass
break break
@@ -1061,12 +1062,17 @@ class MemoryAnalyzer:
check=True, check=True,
) )
# Track seen addresses to avoid duplicates
seen_addresses: set[str] = set()
for line in result.stdout.splitlines(): for line in result.stdout.splitlines():
symbol_info = parse_symbol_line(line) symbol_info = parse_symbol_line(line)
if symbol_info: if symbol_info:
section, name, size = symbol_info section, name, size, address = symbol_info
if section in self.sections: # Skip duplicate symbols at the same address (e.g., C1/C2 constructors)
if address not in seen_addresses and section in self.sections:
self.sections[section].symbols.append((name, size, "")) self.sections[section].symbols.append((name, size, ""))
seen_addresses.add(address)
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
_LOGGER.error(f"Failed to parse symbols: {e}") _LOGGER.error(f"Failed to parse symbols: {e}")
@@ -1468,9 +1474,8 @@ class MemoryAnalyzer:
self._esphome_core_symbols, key=lambda x: x[2], reverse=True self._esphome_core_symbols, key=lambda x: x[2], reverse=True
) )
MAX_SYMBOL_LENGTH = 80
for i, (symbol, demangled, size) in enumerate(sorted_core_symbols[:10]): for i, (symbol, demangled, size) in enumerate(sorted_core_symbols[:10]):
lines.append(f"{i + 1}. {demangled[:MAX_SYMBOL_LENGTH]} ({size:,} B)") lines.append(f"{i + 1}. {demangled} ({size:,} B)")
lines.append("=" * table_width) lines.append("=" * table_width)
@@ -1504,11 +1509,8 @@ class MemoryAnalyzer:
lines.append("") lines.append("")
lines.append(f"Top 10 Largest {comp_name} Symbols:") lines.append(f"Top 10 Largest {comp_name} Symbols:")
MAX_SYMBOL_LENGTH = 80
for i, (symbol, demangled, size) in enumerate(sorted_symbols[:10]): for i, (symbol, demangled, size) in enumerate(sorted_symbols[:10]):
lines.append( lines.append(f"{i + 1}. {demangled} ({size:,} B)")
f"{i + 1}. {demangled[:MAX_SYMBOL_LENGTH]} ({size:,} B)"
)
lines.append("=" * table_width) lines.append("=" * table_width)