sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-01-31 10:10:56 +00:00
Code Issues Releases Wiki Activity

Clean up dashboard ping result post-rename/delete (#4170)

Browse Source
This commit is contained in:
Paulus Schoutsen 2023-01-15 19:31:03 -05:00 committed by GitHub
parent a9b7d98194
commit 27185265f6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
esphome/dashboard/dashboard.py
View File

@ -281,8 +281,11 @@ class EsphomeLogsHandler(EsphomeCommandWebSocket):
class EsphomeRenameHandler(EsphomeCommandWebSocket): class EsphomeRenameHandler(EsphomeCommandWebSocket):
old_name: str
def build_command(self, json_message): def build_command(self, json_message):
config_file = settings.rel_path(json_message["configuration"]) config_file = settings.rel_path(json_message["configuration"])
self.old_name = json_message["configuration"]
return [ return [
"esphome", "esphome",
"--dashboard", "--dashboard",
@ -291,6 +294,15 @@ class EsphomeRenameHandler(EsphomeCommandWebSocket):
json_message["newName"], json_message["newName"],
] ]
def _proc_on_exit(self, returncode):
super()._proc_on_exit(returncode)
if returncode != 0:
return
# Remove the old ping result from the cache
PING_RESULT.pop(self.old_name, None)
class EsphomeUploadHandler(EsphomeCommandWebSocket): class EsphomeUploadHandler(EsphomeCommandWebSocket):
def build_command(self, json_message): def build_command(self, json_message):
@ -859,6 +871,9 @@ class DeleteRequestHandler(BaseHandler):
if build_folder is not None: if build_folder is not None:
shutil.rmtree(build_folder, os.path.join(trash_path, name)) shutil.rmtree(build_folder, os.path.join(trash_path, name))
# Remove the old ping result from the cache
PING_RESULT.pop(configuration, None)
class UndoDeleteRequestHandler(BaseHandler): class UndoDeleteRequestHandler(BaseHandler):
@authenticated @authenticated