cleanup

esphome/core/helpers.h

@@ -170,10 +170,13 @@ template<typename T> class FixedVector {
 
   // Helper to destroy all elements without freeing memory
   void destroy_elements_() {
+    // Only call destructors for non-trivially destructible types
+    if constexpr (!std::is_trivially_destructible<T>::value) {
       for (size_t i = 0; i < size_; i++) {
         data_[i].~T();
       }
     }
+  }
 
   // Helper to destroy elements and free memory
   void cleanup_() {
@@ -221,7 +224,7 @@ template<typename T> class FixedVector {
     reset_();
     if (n > 0) {
       // Allocate raw memory without calling constructors
-      // sizeof(T) is correct here - when T is a pointer type, we want the pointer size
+      // sizeof(T) is correct here for any type T (value types, pointers, etc.)
       // NOLINTNEXTLINE(bugprone-sizeof-expression)
       data_ = static_cast<T *>(::operator new(n * sizeof(T)));
       capacity_ = n;
@@ -265,17 +268,13 @@ template<typename T> class FixedVector {
   /// Emplace element without bounds checking - constructs in-place
   /// Caller must ensure sufficient capacity was allocated via init()
   /// Returns reference to the newly constructed element
-  /// Silently ignores emplaces beyond capacity (returns reference to last element)
+  /// NOTE: Caller MUST ensure size_ < capacity_ before calling
   T &emplace_back() {
-    if (size_ < capacity_) {
     // Use placement new to default-construct the object in pre-allocated memory
     new (&data_[size_]) T();
     size_++;
     return data_[size_ - 1];
   }
-    // Beyond capacity - return reference to last element to avoid crash
-    return data_[size_ - 1];
-  }
 
   /// Access last element (no bounds checking - matches std::vector behavior)
   /// Caller must ensure vector is not empty (size() > 0)