From 0d256e12a6ea805e3067e141e6f00bc84ae9065f Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Tue, 21 Oct 2025 22:37:48 -1000 Subject: [PATCH] [climate] Remove redundant initializer_list overloads from haier and midea EnumBitmask and std::vector already handle initializer_list via implicit conversion, so explicit overloads are unnecessary. --- esphome/components/haier/haier_base.cpp | 12 ------------ esphome/components/midea/air_conditioner.h | 11 ----------- 2 files changed, 23 deletions(-) diff --git a/esphome/components/haier/haier_base.cpp b/esphome/components/haier/haier_base.cpp index 1fc971a04e..cd2673a272 100644 --- a/esphome/components/haier/haier_base.cpp +++ b/esphome/components/haier/haier_base.cpp @@ -177,10 +177,6 @@ void HaierClimateBase::set_supported_swing_modes(climate::ClimateSwingModeMask m this->traits_.add_supported_swing_mode(climate::CLIMATE_SWING_OFF); } -void HaierClimateBase::set_supported_swing_modes(std::initializer_list modes) { - this->set_supported_swing_modes(climate::ClimateSwingModeMask(modes)); -} - void HaierClimateBase::set_answer_timeout(uint32_t timeout) { this->haier_protocol_.set_answer_timeout(timeout); } void HaierClimateBase::set_supported_modes(climate::ClimateModeMask modes) { @@ -189,20 +185,12 @@ void HaierClimateBase::set_supported_modes(climate::ClimateModeMask modes) { this->traits_.add_supported_mode(climate::CLIMATE_MODE_HEAT_COOL); // Always available } -void HaierClimateBase::set_supported_modes(std::initializer_list modes) { - this->set_supported_modes(climate::ClimateModeMask(modes)); -} - void HaierClimateBase::set_supported_presets(climate::ClimatePresetMask presets) { this->traits_.set_supported_presets(presets); if (!presets.empty()) this->traits_.add_supported_preset(climate::CLIMATE_PRESET_NONE); } -void HaierClimateBase::set_supported_presets(std::initializer_list presets) { - this->set_supported_presets(climate::ClimatePresetMask(presets)); -} - void HaierClimateBase::set_send_wifi(bool send_wifi) { this->send_wifi_signal_ = send_wifi; } void HaierClimateBase::send_custom_command(const haier_protocol::HaierMessage &message) { diff --git a/esphome/components/midea/air_conditioner.h b/esphome/components/midea/air_conditioner.h index 60ee096ec6..6c2401efe7 100644 --- a/esphome/components/midea/air_conditioner.h +++ b/esphome/components/midea/air_conditioner.h @@ -44,21 +44,10 @@ class AirConditioner : public ApplianceBase, void do_power_off() { this->base_.setPowerState(false); } void do_power_toggle() { this->base_.setPowerState(this->mode == ClimateMode::CLIMATE_MODE_OFF); } void set_supported_modes(ClimateModeMask modes) { this->supported_modes_ = modes; } - void set_supported_modes(std::initializer_list modes) { - this->supported_modes_ = ClimateModeMask(modes); - } void set_supported_swing_modes(ClimateSwingModeMask modes) { this->supported_swing_modes_ = modes; } - void set_supported_swing_modes(std::initializer_list modes) { - this->supported_swing_modes_ = ClimateSwingModeMask(modes); - } void set_supported_presets(ClimatePresetMask presets) { this->supported_presets_ = presets; } - void set_supported_presets(std::initializer_list presets) { - this->supported_presets_ = ClimatePresetMask(presets); - } void set_custom_presets(const std::vector &presets) { this->supported_custom_presets_ = presets; } - void set_custom_presets(std::initializer_list presets) { this->supported_custom_presets_ = presets; } void set_custom_fan_modes(const std::vector &modes) { this->supported_custom_fan_modes_ = modes; } - void set_custom_fan_modes(std::initializer_list modes) { this->supported_custom_fan_modes_ = modes; } protected: void control(const ClimateCall &call) override;