From 03dd169f1b91bbba7ded2629fb1774cca58e2471 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Fri, 3 Oct 2025 08:02:45 -0500 Subject: [PATCH] fix --- esphome/components/text/text_traits.h | 2 +- esphome/components/web_server_base/web_server_base.h | 4 ++-- esphome/components/web_server_idf/multipart.h | 4 +++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/esphome/components/text/text_traits.h b/esphome/components/text/text_traits.h index ceaba2dead..54b3873a1b 100644 --- a/esphome/components/text/text_traits.h +++ b/esphome/components/text/text_traits.h @@ -22,7 +22,7 @@ class TextTraits { int get_max_length() const { return this->max_length_; } // Set/get the pattern. - void set_pattern(std::string pattern) { this->pattern_ = std::move(pattern); } + void set_pattern(const std::string &pattern) { this->pattern_ = std::move(pattern); } std::string get_pattern() const { return this->pattern_; } StringRef get_pattern_ref() const { return StringRef(this->pattern_); } diff --git a/esphome/components/web_server_base/web_server_base.h b/esphome/components/web_server_base/web_server_base.h index 039a452d64..d3bcfb2c3c 100644 --- a/esphome/components/web_server_base/web_server_base.h +++ b/esphome/components/web_server_base/web_server_base.h @@ -131,8 +131,8 @@ class WebServerBase : public Component { float get_setup_priority() const override; #ifdef USE_WEBSERVER_AUTH - void set_auth_username(std::string auth_username) { credentials_.username = std::move(auth_username); } - void set_auth_password(std::string auth_password) { credentials_.password = std::move(auth_password); } + void set_auth_username(const std::string &auth_username) { credentials_.username = std::move(auth_username); } + void set_auth_password(const std::string &auth_password) { credentials_.password = std::move(auth_password); } #endif void add_handler(AsyncWebHandler *handler); diff --git a/esphome/components/web_server_idf/multipart.h b/esphome/components/web_server_idf/multipart.h index 8fbe90c4a0..7f43023408 100644 --- a/esphome/components/web_server_idf/multipart.h +++ b/esphome/components/web_server_idf/multipart.h @@ -35,7 +35,9 @@ class MultipartReader { // Set callbacks for handling data void set_data_callback(DataCallback callback) { data_callback_ = std::move(callback); } - void set_part_complete_callback(PartCompleteCallback callback) { part_complete_callback_ = std::move(callback); } + void set_part_complete_callback(const PartCompleteCallback &callback) { + part_complete_callback_ = std::move(callback); + } // Parse incoming data size_t parse(const char *data, size_t len);