sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-09-11 15:52:20 +01:00
Code Issues Releases Wiki Activity

validate sooner

Browse Source
This commit is contained in:
J. Nick Koston
2025-06-22 21:04:42 +02:00
parent 7be12f5ff6
commit 02019dd16c
2 changed files with 48 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/unit_tests/core/test_config.py
View File

@@ -172,11 +172,8 @@ def test_area_id_collision(
# Check for the specific error message in stdout
captured = capsys.readouterr()
# Since duplicate IDs have the same hash, our hash collision detection catches this
assert (
"Area ID 'duplicate_id' with hash 1805131238 collides with existing area ID 'duplicate_id'"
in captured.out
)
# Exact duplicates are now caught by IDPassValidationStep
assert "ID duplicate_id redefined! Check esphome->area->id." in captured.out
def test_device_without_area(yaml_file: Callable[[str], str]) -> None:
@@ -241,3 +238,15 @@ def test_area_id_hash_collision(
"Area ID 'd6ka' with hash 3082558663 collides with existing area ID 'test_2258'"
in captured.out
)
def test_device_duplicate_id(
yaml_file: Callable[[str], str], capsys: pytest.CaptureFixture[str]
) -> None:
"""Test that duplicate device IDs are detected by IDPassValidationStep."""
result = load_config_from_fixture(yaml_file, "device_duplicate_id.yaml")
assert result is None
# Check for the specific error message from IDPassValidationStep
captured = capsys.readouterr()
assert "ID duplicate_device redefined!" in captured.out