sascha/devlib
1
0
Fork 0
mirror of https://github.com/ARM-software/devlib.git synced 2025-11-04 07:51:21 +00:00
Code Issues Releases Wiki Activity

trace/ftrace: Memoize tracable functions

Browse Source 
This is similar to what is already done for events and tracers. Also, use
this opportunity to use read_value() instead of target.execute('cat {}').
This commit is contained in:
Valentin Schneider
2019-11-26 17:50:35 +00:00
committed by Marc Bonnici
parent 72be3d01f8
commit e7bd2a5b22
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
devlib/trace/ftrace.py
View File

@@ -162,13 +162,10 @@ class FtraceCollector(TraceCollector):
# Check for function tracing support # Check for function tracing support
if self.functions: if self.functions:
# Validate required functions to be traced # Validate required functions to be traced
available_functions = self.target.execute(
'cat {}'.format(self.available_functions_file),
as_root=True).splitlines()
selected_functions = [] selected_functions = []
for function in self.functions: for function in self.functions:
if function not in available_functions: if function not in self.available_functions:
message = 'Function [{}] not available for profiling'.format(function) message = 'Function [{}] not available for tracing/profiling'.format(function)
if self.strict: if self.strict:
raise TargetStableError(message) raise TargetStableError(message)
self.target.logger.warning(message) self.target.logger.warning(message)
@@ -209,6 +206,14 @@ class FtraceCollector(TraceCollector):
""" """
return self.target.read_value(self.available_events_file).splitlines() return self.target.read_value(self.available_events_file).splitlines()
@property
@memoized
def available_functions(self):
"""
List of functions whose tracing/profiling is supported by the target's kernel.
"""
return self.target.read_value(self.available_functions_file).splitlines()
def reset(self): def reset(self):
if self.buffer_size: if self.buffer_size:
self._set_buffer_size() self._set_buffer_size()