From ac0c39e31ae60796f3ea435ddd1e47334dd36bd4 Mon Sep 17 00:00:00 2001 From: Douglas Raillard Date: Wed, 17 May 2023 10:01:39 +0100 Subject: [PATCH] connection: Make BackgroundCommand.wait() return non-None Lack of return statement in wait() was making it return None instead of the exit code. Add appropriate return statement in wait() and other function to ensure return value is not lost. --- devlib/connection.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/devlib/connection.py b/devlib/connection.py index dbc41f0..a857a57 100644 --- a/devlib/connection.py +++ b/devlib/connection.py @@ -170,7 +170,7 @@ class BackgroundCommand(ABC): :type signal: signal.Signals """ try: - self._send_signal(sig) + return self._send_signal(sig) finally: # Deregister if the command has finished self.poll() @@ -188,7 +188,7 @@ class BackgroundCommand(ABC): """ try: if self.poll() is None: - self._cancel(kill_timeout=kill_timeout) + return self._cancel(kill_timeout=kill_timeout) finally: self._deregister() @@ -208,7 +208,7 @@ class BackgroundCommand(ABC): Block until the background command completes, and return its exit code. """ try: - self._wait() + return self._wait() finally: self._deregister()