sascha/devlib
1
0
Fork 0
mirror of https://github.com/ARM-software/devlib.git synced 2025-01-31 02:00:45 +00:00
Code Issues Releases Wiki Activity

utils.adb_shell: Move from 'echo CMD | su' to '-c'

Browse Source 
Move from the current implementation (piping the command to su) which
has unexpected behaviours to the '-c' su flag (which then becomes
required).
This commit is contained in:
Pierre-Clément Tosi 2019-05-14 12:22:23 +01:00 committed by Marc Bonnici
parent 0d798f1c4f
commit 6b414cc291
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
devlib/utils/android.py
View File

@ -431,7 +431,7 @@ def adb_shell(device, command, timeout=None, check_exit_code=False,
if device is not None: if device is not None:
parts += ['-s', device] parts += ['-s', device]
parts += ['shell', parts += ['shell',
command if not as_root else 'echo {} | su'.format(quote(command))] command if not as_root else 'su -c {}'.format(quote(command))]
logger.debug(' '.join(quote(part) for part in parts)) logger.debug(' '.join(quote(part) for part in parts))
# On older combinations of ADB/Android versions, the adb host command always # On older combinations of ADB/Android versions, the adb host command always