sascha/devlib
1
0
Fork 0
mirror of https://github.com/ARM-software/devlib.git synced 2025-11-04 07:51:21 +00:00
Code Issues Releases Wiki Activity

cgroups: explicitly check for proper CGroup naming

Browse Source 
The shutils run_into support assumes that we always specify a full
cgroup path starting by "/". If, by error, we specify a cgroup name
without the leading "/" we get an ambiguous message about the cgroup not
being found.

Since this already happened to me many times, let's add an explicit
check about the cgroup name parameter to better info the user about the
requirement.

Signed-off-by: Patrick Bellasi <patrick.bellasi@arm.com>
This commit is contained in:
Patrick Bellasi
2018-07-18 15:59:02 +01:00
committed by Marc Bonnici
parent df61b2a269
commit 68b418dac2
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
devlib/module/cgroups.py
View File

@@ -425,6 +425,9 @@ class CgroupsModule(Module):
:param cgroup: Name of cgroup to run command into :param cgroup: Name of cgroup to run command into
:returns: A command to run `cmdline` into `cgroup` :returns: A command to run `cmdline` into `cgroup`
""" """
if not cgroup.startswith('/'):
message = 'cgroup name "{}" must start with "/"'.format(cgroup)
raise ValueError(message)
return 'CGMOUNT={} {} cgroups_run_into {} {}'\ return 'CGMOUNT={} {} cgroups_run_into {} {}'\
.format(self.cgroup_root, self.target.shutils, .format(self.cgroup_root, self.target.shutils,
cgroup, cmdline) cgroup, cmdline)