sascha/devlib
1
0
Fork 0
mirror of https://github.com/ARM-software/devlib.git synced 2025-01-31 10:10:46 +00:00
Code Issues Releases Wiki Activity

shutils/cgroups: Don't fail when racing with process exit

Browse Source 
If a process is added to $PIDS but then exits before the
cgroups_task_move invokation finishes, then echoing its PID to
cgroups.procs results in an I/O error. If that process is the last in
$PIDS, then that failing echo command is the last of the function, so
the script exits with an error and devlib raises an exception.

Add `|| true` to avoid this problem.
This commit is contained in:
Brendan Jackman 2016-11-28 12:41:41 +00:00
parent 78ac92bd84
commit 454a2d5db5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
devlib/bin/scripts/shutils.in
View File

@ -163,7 +163,7 @@ cgroups_tasks_move() {
for TID in $PIDS; do for TID in $PIDS; do
COMM=`$CAT /proc/$TID/comm` COMM=`$CAT /proc/$TID/comm`
echo "$TID : $COMM" echo "$TID : $COMM"
echo $TID > $SRC_GRP/cgroup.procs echo $TID > $SRC_GRP/cgroup.procs || true
done done
} }