From 3dd4ea69b43c2ebb354b11c81e3dacfeffe5b65f Mon Sep 17 00:00:00 2001 From: Brendan Jackman <brendan.jackman@arm.com> Date: Fri, 25 Nov 2016 16:04:34 +0000 Subject: [PATCH] cgroups: Remove quotes from grep expressions in move_all_tasks_to These quotes end up being passed literally into the shutils function arguments (i.e $3 is '-e', $4 is '"foo"') which means that the grep command never finds matches. `exclude` is a list of comms, which don't have spaces in them, so we can just remove the quotes. --- devlib/module/cgroups.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlib/module/cgroups.py b/devlib/module/cgroups.py index dfd22c4..dd9543e 100644 --- a/devlib/module/cgroups.py +++ b/devlib/module/cgroups.py @@ -155,7 +155,7 @@ class Controller(object): # Build list of tasks to exclude grep_filters = '' for comm in exclude: - grep_filters += '-e "{}" '.format(comm) + grep_filters += '-e {} '.format(comm) logging.debug(' using grep filter: %s', grep_filters) if grep_filters != '': logging.debug(' excluding tasks which name matches:')