sascha/devlib
1
0
Fork 0
mirror of https://github.com/ARM-software/devlib.git synced 2025-01-31 02:00:45 +00:00
Code Issues Releases Wiki Activity

target: Remove use of ls

Browse Source 
Using "ls" in scripts is highly discouraged:
http://mywiki.wooledge.org/ParsingLs
This commit is contained in:
Douglas RAILLARD 2020-01-20 17:15:58 +00:00 committed by Marc Bonnici
parent a5640502ac
commit 0aeb5bc409
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
devlib/target.py
View File

@ -168,9 +168,10 @@ class Target(object):
@memoized @memoized
def number_of_nodes(self): def number_of_nodes(self):
num_nodes = 0 num_nodes = 0
nodere = re.compile(r'^\s*node\d+\s*$') nodere = re.compile(r'^\./node\d+\s*$')
output = self.execute('ls /sys/devices/system/node', as_root=self.is_rooted) cmd = 'cd /sys/devices/system/node && {busybox} find . -maxdepth 1'.format(busybox=quote(self.busybox))
for entry in output.split(): output = self.execute(cmd, as_root=self.is_rooted)
for entry in output.splitlines():
if nodere.match(entry): if nodere.match(entry):
num_nodes += 1 num_nodes += 1
return num_nodes return num_nodes