From a0a16fc30061a71c4fd8459a118daf33185bd3b7 Mon Sep 17 00:00:00 2001
From: Filippo Scognamiglio <flscogna@gmail.com>
Date: Thu, 15 Jan 2026 00:12:18 +0100
Subject: [PATCH] Fix focus issue with multiple windows. Fix build issues with
 previous Qt versions.

---
 app/qml/BurnInEffect.qml         | 2 +-
 app/qml/PreprocessedTerminal.qml | 7 -------
 app/qml/ShaderTerminal.qml       | 2 +-
 app/qml/TerminalTabs.qml         | 6 +++---
 4 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/app/qml/BurnInEffect.qml b/app/qml/BurnInEffect.qml
index ea73568..bc2bd9f 100644
--- a/app/qml/BurnInEffect.qml
+++ b/app/qml/BurnInEffect.qml
@@ -24,7 +24,7 @@ import "utils.js" as Utils
 Loader {
     id: burnInEffect
 
-    property ShaderEffectSource source: item ? item.source : null
+    property ShaderEffectSource effectSource: item ? item.source : null
 
     property real lastUpdate: 0
     property real prevLastUpdate: 0
diff --git a/app/qml/PreprocessedTerminal.qml b/app/qml/PreprocessedTerminal.qml
index c2a0fac..95f00d7 100644
--- a/app/qml/PreprocessedTerminal.qml
+++ b/app/qml/PreprocessedTerminal.qml
@@ -83,13 +83,6 @@ Item{
             terminalContainer.updateSources()
         }
     }
-    Connections {
-        target: terminalWindow
-
-        onActiveChanged: {
-            kterminal.forceActiveFocus()
-        }
-    }
 
     function updateSources() {
         kterminal.update()
diff --git a/app/qml/ShaderTerminal.qml b/app/qml/ShaderTerminal.qml
index 69a8451..4d791f1 100644
--- a/app/qml/ShaderTerminal.qml
+++ b/app/qml/ShaderTerminal.qml
@@ -73,7 +73,7 @@ Item {
         id: dynamicShader
 
         property ShaderEffectSource screenBuffer: frameBuffer
-        property ShaderEffectSource burnInSource: burnInEffect.source
+        property ShaderEffectSource burnInSource: burnInEffect.effectSource
         property ShaderEffectSource frameSource: terminalFrameLoader.item
 
         property color fontColor: parent.fontColor
diff --git a/app/qml/TerminalTabs.qml b/app/qml/TerminalTabs.qml
index 8fce43a..361a172 100644
--- a/app/qml/TerminalTabs.qml
+++ b/app/qml/TerminalTabs.qml
@@ -130,9 +130,9 @@ Item {
             Repeater {
                 model: tabsModel
                 TerminalContainer {
-                    property bool isCurrentItem: StackLayout.isCurrentItem
-                    onIsCurrentItemChanged: {
-                        if (isCurrentItem) {
+                    property bool shouldHaveFocus: terminalWindow.active && StackLayout.isCurrentItem
+                    onShouldHaveFocusChanged: {
+                        if (shouldHaveFocus) {
                             activate()
                         }
                     }