From 29e8592582ba499e52b3c259adb2a621f7b29eeb Mon Sep 17 00:00:00 2001 From: Filippo Scognamiglio Date: Sun, 14 Dec 2014 18:53:37 +0100 Subject: [PATCH] Optimization: Allow finer bloom quality settings. Also set default value to 50%, good compromise between speed and quality. --- app/qml/ApplicationSettings.qml | 2 +- app/qml/SettingsPerformanceTab.qml | 32 ++++++------------------------ 2 files changed, 7 insertions(+), 27 deletions(-) diff --git a/app/qml/ApplicationSettings.qml b/app/qml/ApplicationSettings.qml index 0d616f3..1bf23da 100644 --- a/app/qml/ApplicationSettings.qml +++ b/app/qml/ApplicationSettings.qml @@ -57,7 +57,7 @@ Item{ property real motion_blur: 0.40 property real bloom_strength: 0.65 - property real bloom_quality: 1.0 + property real bloom_quality: 0.5 property real chroma_color: 0.0 property real saturation_color: 0.0 diff --git a/app/qml/SettingsPerformanceTab.qml b/app/qml/SettingsPerformanceTab.qml index 5e69334..1d5b995 100644 --- a/app/qml/SettingsPerformanceTab.qml +++ b/app/qml/SettingsPerformanceTab.qml @@ -111,37 +111,17 @@ Tab{ GridLayout{ id: bloomQualityContainer anchors.fill: parent - columns: 3 - property alias valsIndex: bloomQualitySlider.value - property var vals: [0.25, 0.50, 1.00] - property var valsStrings: [ - qsTr("Low"), - qsTr("Medium"), - qsTr("High") - ] - - onValsIndexChanged: appSettings.bloom_quality = vals[valsIndex]; Text{text: qsTr("Bloom Quality")} Slider{ - id: bloomQualitySlider Layout.fillWidth: true - onValueChanged: parent.valsIndex = value; - stepSize: 1 - Component.onCompleted: { - minimumValue = 0; - maximumValue = 2; - value = parent.vals.indexOf(appSettings.bloom_quality); - } - Connections{ - target: appSettings - onBloom_qualityChanged: - bloomQualityContainer.valsIndex = bloomQualityContainer.vals.indexOf(appSettings.bloom_quality); - } - } - Text{ - text: parent.valsStrings[parent.valsIndex]; + id: bloomSlider + onValueChanged: appSettings.bloom_quality = value; + value: appSettings.bloom_quality + stepSize: 0.10 + Component.onCompleted: minimumValue = 0.3 //Without this value gets set to 0.5 } + Text{text: Math.round(bloomSlider.value * 100) + "%"} } } GroupBox{