From 916dfae6ddfe293be37d19f3e6c864c36479c5a5 Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Thu, 6 Jul 2017 00:10:27 +0200 Subject: [PATCH 1/3] Remove `brew upgrade --all` rule. --- thefuck/rules/brew_upgrade.py | 17 ----------------- 1 file changed, 17 deletions(-) delete mode 100644 thefuck/rules/brew_upgrade.py diff --git a/thefuck/rules/brew_upgrade.py b/thefuck/rules/brew_upgrade.py deleted file mode 100644 index 8f6d40db..00000000 --- a/thefuck/rules/brew_upgrade.py +++ /dev/null @@ -1,17 +0,0 @@ -# Appends --all to the brew upgrade command -# -# Example: -# > brew upgrade -# Warning: brew upgrade with no arguments will change behaviour soon! -# It currently upgrades all formula but this will soon change to require '--all'. -from thefuck.specific.brew import brew_available - -enabled_by_default = brew_available - - -def match(command): - return command.script == 'brew upgrade' - - -def get_new_command(command): - return command.script + ' --all' From a1da33493e7eec5a2bdc7440beaf0172b41853be Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Thu, 6 Jul 2017 00:20:46 +0200 Subject: [PATCH 2/3] Delete test_brew_upgrade.py --- tests/rules/test_brew_upgrade.py | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 tests/rules/test_brew_upgrade.py diff --git a/tests/rules/test_brew_upgrade.py b/tests/rules/test_brew_upgrade.py deleted file mode 100644 index e1afc8ee..00000000 --- a/tests/rules/test_brew_upgrade.py +++ /dev/null @@ -1,15 +0,0 @@ -import pytest -from thefuck.rules.brew_upgrade import match, get_new_command -from tests.utils import Command - - -@pytest.mark.parametrize('command', [ - Command(script='brew upgrade')]) -def test_match(command): - assert match(command) - - -@pytest.mark.parametrize('command, new_command', [ - (Command('brew upgrade'), 'brew upgrade --all')]) -def test_get_new_command(command, new_command): - assert get_new_command(command) == new_command From 50db76c019bd9469ab752540d6527d7eee1607cf Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Thu, 6 Jul 2017 00:21:31 +0200 Subject: [PATCH 3/3] Update README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 27e8b9ec..4b3fbdb5 100644 --- a/README.md +++ b/README.md @@ -272,7 +272,6 @@ Enabled by default only on specific platforms: * `brew_uninstall` – adds `--force` to `brew uninstall` if multiple versions were installed; * `brew_unknown_command` – fixes wrong brew commands, for example `brew docto/brew doctor`; * `brew_update_formula` – turns `brew update ` into `brew upgrade `; -* `brew_upgrade` – appends `--all` to `brew upgrade` as per Homebrew's new behaviour; * `pacman` – installs app with `pacman` if it is not installed (uses `yaourt` if available); * `pacman_not_found` – fixes package name with `pacman` or `yaourt`.