From af28f0334a62bd682f820ab1b505c1f396ed8ec1 Mon Sep 17 00:00:00 2001 From: Pablo Santiago Blum de Aguiar Date: Sat, 29 Oct 2016 17:41:36 -0200 Subject: [PATCH] #N/A: Add `git_rm_local_modifications` rule --- README.md | 1 + .../rules/test_git_rm_local_modifications.py | 28 +++++++++++++++++++ thefuck/rules/git_rm_local_modifications.py | 19 +++++++++++++ 3 files changed, 48 insertions(+) create mode 100644 tests/rules/test_git_rm_local_modifications.py create mode 100644 thefuck/rules/git_rm_local_modifications.py diff --git a/README.md b/README.md index b158c807..aedaf1b2 100644 --- a/README.md +++ b/README.md @@ -181,6 +181,7 @@ using the matched rule and runs it. Rules enabled by default are as follows: * `git_push` – adds `--set-upstream origin $branch` to previous failed `git push`; * `git_push_pull` – runs `git pull` when `push` was rejected; * `git_rebase_no_changes` – runs `git rebase --skip` instead of `git rebase --continue` when there are no changes; +* `git_rm_local_modifications` – adds `-f` or `--cached` when you try to `rm` a locally modified file; * `git_rm_recursive` – adds `-r` when you try to `rm` a directory; * `git_remote_seturl_add` – runs `git remote add` when `git remote set_url` on nonexistant remote; * `git_stash` – stashes you local modifications before rebasing or switching branch; diff --git a/tests/rules/test_git_rm_local_modifications.py b/tests/rules/test_git_rm_local_modifications.py new file mode 100644 index 00000000..1b0a4df6 --- /dev/null +++ b/tests/rules/test_git_rm_local_modifications.py @@ -0,0 +1,28 @@ +import pytest +from thefuck.rules.git_rm_local_modifications import match, get_new_command +from tests.utils import Command + + +@pytest.fixture +def stderr(target): + return ('error: the following file has local modifications:\n {}\n(use ' + '--cached to keep the file, or -f to force removal)').format(target) + + +@pytest.mark.parametrize('script, target', [ + ('git rm foo', 'foo'), + ('git rm foo bar', 'bar')]) +def test_match(stderr, script, target): + assert match(Command(script=script, stderr=stderr)) + + +@pytest.mark.parametrize('script', ['git rm foo', 'git rm foo bar', 'git rm']) +def test_not_match(script): + assert not match(Command(script=script, stderr='')) + + +@pytest.mark.parametrize('script, target, new_command', [ + ('git rm foo', 'foo', ['git rm --cached foo', 'git rm -f foo']), + ('git rm foo bar', 'bar', ['git rm --cached foo bar', 'git rm -f foo bar'])]) +def test_get_new_command(stderr, script, target, new_command): + assert get_new_command(Command(script=script, stderr=stderr)) == new_command diff --git a/thefuck/rules/git_rm_local_modifications.py b/thefuck/rules/git_rm_local_modifications.py new file mode 100644 index 00000000..01b8de42 --- /dev/null +++ b/thefuck/rules/git_rm_local_modifications.py @@ -0,0 +1,19 @@ +from thefuck.specific.git import git_support + + +@git_support +def match(command): + return (' rm ' in command.script and + 'error: the following file has local modifications' in command.stderr and + 'use --cached to keep the file, or -f to force removal' in command.stderr) + + +@git_support +def get_new_command(command): + command_parts = command.script_parts[:] + index = command_parts.index('rm') + 1 + command_parts.insert(index, '--cached') + command_list = [u' '.join(command_parts)] + command_parts[index] = '-f' + command_list.append(u' '.join(command_parts)) + return command_list