From 8bd6c5da67e55c64257345efa4e3cc454c42475c Mon Sep 17 00:00:00 2001 From: Joseph Frazier <1212jtraceur@gmail.com> Date: Mon, 3 Oct 2016 11:54:29 -0400 Subject: [PATCH] For `man foo`, try `foo --help` before `man 3 foo` `man` without a section searches all sections, so having `foo --help` suggested first makes more sense than adding a specific section. See https://github.com/nvbn/thefuck/pull/562#issuecomment-251142710 However, in cases where multiple sections have man pages for `foo`, running `man foo` could bring up the "wrong" section of man pages. `man read` is an example of this, but that should probably be handled in a way that still suggests `foo --help` first when there are *no* man pages for `foo` in any section. Closes https://github.com/nvbn/thefuck/issues/546 --- tests/rules/test_man.py | 2 +- thefuck/rules/man.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/rules/test_man.py b/tests/rules/test_man.py index 1c9095ca..b51b1165 100644 --- a/tests/rules/test_man.py +++ b/tests/rules/test_man.py @@ -23,7 +23,7 @@ def test_not_match(command): @pytest.mark.parametrize('command, new_command', [ - (Command('man read'), ['man 3 read', 'man 2 read', 'read --help']), + (Command('man read'), ['read --help', 'man 3 read', 'man 2 read']), (Command('man 2 read'), 'man 3 read'), (Command('man 3 read'), 'man 2 read'), (Command('man -s2 read'), 'man -s3 read'), diff --git a/thefuck/rules/man.py b/thefuck/rules/man.py index 6fcea5af..3d0347a8 100644 --- a/thefuck/rules/man.py +++ b/thefuck/rules/man.py @@ -21,7 +21,7 @@ def get_new_command(command): last_arg = command.script_parts[-1] return [ + last_arg + ' --help', "".join(split_cmd3), "".join(split_cmd2), - last_arg + ' --help', ]