#52 Use cp -a, add tests

tests/rules/test_cp_omitting_directory.py

@@ -0,0 +1,14 @@
+from mock import Mock
+from thefuck.rules.cp_omitting_directory import match, get_new_command
+
+
+def test_match():
+    assert match(Mock(script='cp dir', stderr="cp: omitting directory 'dir'"),
+                 None)
+    assert not match(Mock(script='some dir',
+                          stderr="cp: omitting directory 'dir'"), None)
+    assert not match(Mock(script='cp dir', stderr=""), None)
+
+
+def test_get_new_command():
+    assert get_new_command(Mock(script='cp dir'), None) == 'cp -a dir'

thefuck/rules/cp_omitting_directory.py

@@ -1,10 +1,10 @@
+import re
+
+
 def match(command, settings):
-    if 'cp: omitting directory' in command.stderr.lower():
+    return command.script.startswith('cp ') \
-        return True
+        and 'cp: omitting directory' in command.stderr.lower()
-    return False
 
 
 def get_new_command(command, settings):
-    return command.script.replace('cp', 'cp -r') 
+    return re.sub(r'^cp', 'cp -a', command.script)
-
-