#960: Improve pacman_invalid_option rule (#1072)

The rule now matches all possible lower case options and only those, not
failing for those that cannot be fixed.

tests/rules/test_pacman_invalid_option.py

@@ -1,21 +1,30 @@
+import pytest
 from thefuck.rules.pacman_invalid_option import get_new_command, match
 from thefuck.types import Command
 
-good_output = "community/shared_meataxe 1.0-3\n    A set of programs for working with matrix representations over finite fields\n    "
+good_output = """community/shared_meataxe 1.0-3
+    A set of programs for working with matrix representations over finite fields
+"""
 
-bad_output = "error: invalid option '-s'"
+bad_output = "error: invalid option '-"
 
 
-def test_match():
-    assert not match(Command('pacman -Ss meat', good_output))
-    assert not match(Command('sudo pacman -Ss meat', good_output))
-    assert match(Command('pacman -ss meat', bad_output))
-    assert match(Command('sudo pacman -ss meat', bad_output))
+@pytest.mark.parametrize("option", "SURQFDVT")
+def test_not_match_good_output(option):
+    assert not match(Command("pacman -{}s meat".format(option), good_output))
 
 
-def test_get_new_command():
-    new_command = get_new_command(Command('pacman -ss meat', bad_output))
-    assert new_command == 'pacman -Ss meat'
+@pytest.mark.parametrize("option", "azxcbnm")
+def test_not_match_bad_output(option):
+    assert not match(Command("pacman -{}v meat".format(option), bad_output))
 
-    new_command = get_new_command(Command('sudo pacman -s meat', bad_output))
-    assert new_command == 'sudo pacman -S meat'
+
+@pytest.mark.parametrize("option", "surqfdvt")
+def test_match(option):
+    assert match(Command("pacman -{}v meat".format(option), bad_output))
+
+
+@pytest.mark.parametrize("option", "surqfdvt")
+def test_get_new_command(option):
+    new_command = get_new_command(Command("pacman -{}v meat".format(option), ""))
+    assert new_command == "pacman -{}v meat".format(option.upper())