MirroredRepos/thefuck
1
0
Fork 0
mirror of https://github.com/nvbn/thefuck.git synced 2025-02-22 12:58:33 +00:00
Code Issues Releases Wiki Activity

Avoid masking shell return values in Zsh.app_alias (#820)

Browse Source 
I discovered that a common shell script issue (https://github.com/koalaman/shellcheck/wiki/SC2155) is present in the script returned by `Zsh.app_alias()`, amongst other `app_alias` methods in thefuck.

In the case of the zsh `app_alias()` script, this common issue is causing the script to error on some versions of Mac OS X. This is  reported in #718.

Unmasking the value of `TF_SHELL_ALIASES` fixes the errors in Mac OS X, but I also unmasked `TF_HISTORY` for consistency.
This commit is contained in:
Chris Mendis 2018-07-09 18:48:56 -04:00 committed by Vladimir Iakovlev
parent 534782414f
commit 692ee53a33
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
thefuck/shells/zsh.py
View File

@ -16,8 +16,10 @@ class Zsh(Generic):
TF_PYTHONIOENCODING=$PYTHONIOENCODING; TF_PYTHONIOENCODING=$PYTHONIOENCODING;
export TF_SHELL=zsh; export TF_SHELL=zsh;
export TF_ALIAS={name}; export TF_ALIAS={name};
export TF_SHELL_ALIASES=$(alias); TF_SHELL_ALIASES=$(alias);
export TF_HISTORY="$(fc -ln -10)"; export TF_SHELL_ALIASES;
TF_HISTORY="$(fc -ln -10)";
export TF_HISTORY;
export PYTHONIOENCODING=utf-8; export PYTHONIOENCODING=utf-8;
TF_CMD=$( TF_CMD=$(
thefuck {argument_placeholder} $@ thefuck {argument_placeholder} $@