MirroredRepos/thefuck
1
0
Fork 0
mirror of https://github.com/nvbn/thefuck.git synced 2025-01-31 02:01:13 +00:00
Code Issues Releases Wiki Activity

#N/A: Improve support to Windows in no_command rule (#918)

Browse Source 
Windows “not found” message is quite different from POSIX systems.
This commit is contained in:
Pablo Aguiar 2019-05-27 18:23:06 +02:00 committed by Vladimir Iakovlev
parent 70a13406f0
commit 5efcf1019f
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/rules/test_no_command.py
View File

@ -6,7 +6,7 @@ from thefuck.types import Command
@pytest.fixture(autouse=True) @pytest.fixture(autouse=True)
def get_all_executables(mocker): def get_all_executables(mocker):
mocker.patch('thefuck.rules.no_command.get_all_executables', mocker.patch('thefuck.rules.no_command.get_all_executables',
return_value=['vim', 'fsck', 'git', 'go']) return_value=['vim', 'fsck', 'git', 'go', 'python'])
@pytest.fixture(autouse=True) @pytest.fixture(autouse=True)
@ -20,6 +20,7 @@ def history_without_current(mocker):
@pytest.mark.parametrize('script, output', [ @pytest.mark.parametrize('script, output', [
('vom file.py', 'vom: not found'), ('vom file.py', 'vom: not found'),
('fucck', 'fucck: not found'), ('fucck', 'fucck: not found'),
('puthon', "'puthon' is not recognized as an internal or external command"),
('got commit', 'got: command not found')]) ('got commit', 'got: command not found')])
def test_match(mocker, script, output): def test_match(mocker, script, output):
mocker.patch('thefuck.rules.no_command.which', return_value=None) mocker.patch('thefuck.rules.no_command.which', return_value=None)

3
thefuck/rules/no_command.py
View File

@ -6,7 +6,8 @@ from thefuck.specific.sudo import sudo_support
@sudo_support @sudo_support
def match(command): def match(command):
return (not which(command.script_parts[0]) return (not which(command.script_parts[0])
and 'not found' in command.output and ('not found' in command.output
or 'is not recognized as' in command.output)
and bool(get_close_matches(command.script_parts[0], and bool(get_close_matches(command.script_parts[0],
get_all_executables()))) get_all_executables())))