mirror of
				https://github.com/nvbn/thefuck.git
				synced 2025-10-30 22:54:14 +00:00 
			
		
		
		
	#1131: Improve git_commit_add rule
Add more capabilities to the rule, remove its priority and fix tests
This commit is contained in:
		| @@ -3,34 +3,36 @@ from thefuck.rules.git_commit_add import match, get_new_command | ||||
| from thefuck.types import Command | ||||
|  | ||||
|  | ||||
| @pytest.mark.parametrize('script, output', [ | ||||
|     ('git commit -m "test"', 'no changes added to commit'), | ||||
|     ('git commit', 'no changes added to commit')]) | ||||
| @pytest.mark.parametrize( | ||||
|     "script, output", | ||||
|     [ | ||||
|         ('git commit -m "test"', "no changes added to commit"), | ||||
|         ("git commit", "no changes added to commit"), | ||||
|     ], | ||||
| ) | ||||
| def test_match(output, script): | ||||
|     assert match(Command(script, output)) | ||||
|  | ||||
|  | ||||
| @pytest.mark.parametrize('script, output', [ | ||||
|     ('git commit -m "test"', ' 1 file changed, 15 insertions(+), 14 deletions(-)')]) | ||||
| @pytest.mark.parametrize( | ||||
|     "script, output", | ||||
|     [ | ||||
|         ('git commit -m "test"', " 1 file changed, 15 insertions(+), 14 deletions(-)"), | ||||
|         ("git branch foo", ""), | ||||
|         ("git checkout feature/test_commit", ""), | ||||
|         ("git push", ""), | ||||
|     ], | ||||
| ) | ||||
| def test_not_match(output, script): | ||||
|     assert not match(Command(script, output)) | ||||
|  | ||||
|  | ||||
| @pytest.mark.parametrize('script', [ | ||||
|     'git branch foo', | ||||
|     'git checkout feature/test_commit', | ||||
|     'git push']) | ||||
| def test_not_match_either(script): | ||||
|     assert not match(Command(script, '')) | ||||
|  | ||||
|  | ||||
| @pytest.mark.parametrize('script', [ | ||||
|     ('git commit')]) | ||||
| def test_get_new_command_one(script): | ||||
|     assert get_new_command(Command(script, '')) == 'git commit -a' | ||||
|  | ||||
|  | ||||
| @pytest.mark.parametrize('script', [ | ||||
|     ('git commit -m "test commit"')]) | ||||
| def test_get_new_command_two(script): | ||||
|     assert get_new_command(Command(script, '')) == 'git commit -a -m "test commit"' | ||||
| @pytest.mark.parametrize( | ||||
|     "script, new_command", | ||||
|     [ | ||||
|         ("git commit", ["git commit -a", "git commit -p"]), | ||||
|         ('git commit -m "foo"', ['git commit -a -m "foo"', 'git commit -p -m "foo"']), | ||||
|     ], | ||||
| ) | ||||
| def test_get_new_command(script, new_command): | ||||
|     assert get_new_command(Command(script, "")) == new_command | ||||
|   | ||||
		Reference in New Issue
	
	Block a user