From 0d86fce9befd5bd1d73d7cb780fdddf7af3058a6 Mon Sep 17 00:00:00 2001 From: Michael Lee Date: Wed, 26 Aug 2015 14:01:36 +0100 Subject: [PATCH] #35 mvn will auto add clean package --- README.md | 1 + tests/rules/test_mvn_no_command.py | 40 ++++++++++++++++++++++++++++++ thefuck/rules/mvn_no_command.py | 8 ++++++ 3 files changed, 49 insertions(+) create mode 100644 tests/rules/test_mvn_no_command.py create mode 100644 thefuck/rules/mvn_no_command.py diff --git a/README.md b/README.md index 97354dec..a78cd643 100644 --- a/README.md +++ b/README.md @@ -181,6 +181,7 @@ using the matched rule and runs it. Rules enabled by default are as follows: * `man_no_space` – fixes man commands without spaces, for example `mandiff`; * `mercurial` – fixes wrong `hg` commands; * `mkdir_p` – adds `-p` when you trying to create directory without parent; +* `mvn_no_command` – adds `clean package` to `mvn`; * `no_command` – fixes wrong console commands, for example `vom/vim`; * `no_such_file` – creates missing directories with `mv` and `cp` commands; * `open` – prepends `http` to address passed to `open`; diff --git a/tests/rules/test_mvn_no_command.py b/tests/rules/test_mvn_no_command.py new file mode 100644 index 00000000..5725adde --- /dev/null +++ b/tests/rules/test_mvn_no_command.py @@ -0,0 +1,40 @@ +import pytest +from thefuck.rules.mvn_no_command import match, get_new_command +from tests.utils import Command + + +@pytest.mark.parametrize('command', [ + Command(script='mvn', stdout='[ERROR] No goals have been specified for this build. You must specify a valid lifecycle phase or a goal in the format : or :[:]:. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]')]) +def test_match(command): + assert match(command, None) + + +@pytest.mark.parametrize('command', [ + Command(script='mvn clean', stdout=""" +[INFO] Scanning for projects...[INFO] +[INFO] ------------------------------------------------------------------------ +[INFO] Building test 0.2 +[INFO] ------------------------------------------------------------------------ +[INFO] +[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ test --- +[INFO] Deleting /home/mlk/code/test/target +[INFO] ------------------------------------------------------------------------ +[INFO] BUILD SUCCESS +[INFO] ------------------------------------------------------------------------ +[INFO] Total time: 0.477s +[INFO] Finished at: Wed Aug 26 13:05:47 BST 2015 +[INFO] Final Memory: 6M/240M +[INFO] ------------------------------------------------------------------------ +"""), + Command(script='mvn --help'), + Command(script='mvn -v') +]) +def test_not_match(command): + assert not match(command, None) + +@pytest.mark.parametrize('command, new_command', [ + (Command(script='mvn', stdout='[ERROR] No goals have been specified for this build. You must specify a valid lifecycle phase or a goal in the format : or :[:]:. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]'), ['mvn clean package', 'mvn clean install']), + (Command(script='mvn -N', stdout='[ERROR] No goals have been specified for this build. You must specify a valid lifecycle phase or a goal in the format : or :[:]:. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]'), ['mvn -N clean package', 'mvn -N clean install'])]) +def test_get_new_command(command, new_command): + assert get_new_command(command, None) == new_command + diff --git a/thefuck/rules/mvn_no_command.py b/thefuck/rules/mvn_no_command.py new file mode 100644 index 00000000..53c71060 --- /dev/null +++ b/thefuck/rules/mvn_no_command.py @@ -0,0 +1,8 @@ +from thefuck import shells + +def match(command, settings): + return 'No goals have been specified for this build' in command.stdout and command.script.startswith('mvn') + + +def get_new_command(command, settings): + return [ command.script + ' clean package', command.script + ' clean install']