MirroredRepos/bat
1
0
Fork 0
mirror of https://github.com/sharkdp/bat.git synced 2025-10-31 07:04:04 +00:00
Code Issues Releases Wiki Activity

fix: 🐛 allow three-part range parsing

Browse Source 
fix(src/line_range.rs): 🐛 support three-part (start🔚context) syntax, clamp lower at zero and extend upper, and add tests for invalid formats
This commit is contained in:
John Cavanaugh
2025-07-15 16:36:58 -07:00
parent dc2eae08a6
commit bb8c5657e1
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/line_range.rs
View File

@@ -235,14 +235,17 @@ fn test_parse_single() {
#[test] #[test]
fn test_parse_fail() { fn test_parse_fail() {
let range = LineRange::from("40:50:80"); // Test 4+ colon parts should still fail
assert!(range.is_err()); let range = LineRange::from("40:50:80:90");
let range = LineRange::from("40::80");
assert!(range.is_err()); assert!(range.is_err());
// Test invalid formats that should still fail
let range = LineRange::from("-2:5"); let range = LineRange::from("-2:5");
assert!(range.is_err()); assert!(range.is_err());
let range = LineRange::from(":40:"); let range = LineRange::from(":40:");
assert!(range.is_err()); assert!(range.is_err());
// Test completely malformed input
let range = LineRange::from("abc:def");
assert!(range.is_err());
} }
#[test] #[test]
@@ -311,6 +314,11 @@ fn test_parse_context_range() {
let range = LineRange::from("30:40:2").expect("Shouldn't fail on test!"); let range = LineRange::from("30:40:2").expect("Shouldn't fail on test!");
assert_eq!(RangeBound::Absolute(28), range.lower); assert_eq!(RangeBound::Absolute(28), range.lower);
assert_eq!(RangeBound::Absolute(42), range.upper); assert_eq!(RangeBound::Absolute(42), range.upper);
// Test the case that used to fail but should now work
let range = LineRange::from("40:50:80").expect("Shouldn't fail on test!");
assert_eq!(RangeBound::Absolute(0), range.lower); // 40 - 80 = 0 (saturated)
assert_eq!(RangeBound::Absolute(130), range.upper); // 50 + 80 = 130
} }
#[test] #[test]