MirroredRepos/bat
1
0
Fork 0
mirror of https://github.com/sharkdp/bat.git synced 2025-01-18 12:05:52 +00:00
Code Issues Releases Wiki Activity

Fix #1443 macOS: regression_test.sh: mktemp: illegal option (#1444)

Browse Source 
The macOS version of mktemp does not recognize the --suffix option.
Using pure -d should work since, it seems [1], macOS 10.11 however.

So to make the script work on macOS, stop using the --suffix option.

The downside is of course that the temporary dir will have an anonymous
name, but I see no risk of confusion given how short-lived the usage of
the dir is, and given the context it is used.

[1] https://unix.stackexchange.com/questions/30091/fix-or-alternative-for-mktemp-in-os-x
This commit is contained in:
Martin Nordholts 2020-12-21 08:16:49 +01:00 committed by GitHub
parent 2d22c705ba
commit 60e00d49a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -6,6 +6,7 @@
## Bugfixes ## Bugfixes
- only print themes hint in interactive mode (`bat --list-themes`), see #1439 (@rsteube) - only print themes hint in interactive mode (`bat --list-themes`), see #1439 (@rsteube)
- Make ./tests/syntax-tests/regression_test.sh work on recent versions of macOS, see #1443 (@Enselic)
## Other ## Other

2
tests/syntax-tests/regression_test.sh vendored
View File

@ -4,7 +4,7 @@ set -eou pipefail
script_directory="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" script_directory="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
output_directory=$(mktemp -d --suffix=.bat-syntax-regression-test) output_directory=$(mktemp -d)
"$script_directory"/create_highlighted_versions.py --output="$output_directory" "$script_directory"/create_highlighted_versions.py --output="$output_directory"